Bug with Sbuild

Hello, I installed a machine with these properties

       & sbuild (System (Debian Unstable) "i386") (Just proxy)
       & Sbuild.piupartsConfFor (System (Debian Unstable) "i386")
       & Sbuild.updatedFor (System (Debian Unstable) "i386") `period` Weekly (Just 1)
       & Sbuild.usableBy (User "picca")
       & Sbuild.shareAptCache

where

type Proxy = Maybe Url

sbuild :: System -> Proxy -> RevertableProperty (HasInfo + Linux) Linux
sbuild system@(System dist arch) proxy = Sbuild.builtFor system `before` setup
    where
      setup :: RevertableProperty (HasInfo + Linux) Linux
      setup = Chroot.provisioned chroot
      chroot = Chroot.debootstrapped Debootstrap.BuilddD chrootdir $ props
               & os
               & case proxy of
                   (Just p) -> "/etc/apt/apt.conf.d/01proxy" `File.hasContent` ["Acquire::http::Proxy \"" ++ p ++ "\";"]
                   Nothing -> doNothing
               & Apt.installed ["apt-transport-https"]
               & Apt.stdSourcesList
               & Apt.update `onChange` Apt.upgrade
               & Apt.cacheCleaned
      chrootdir :: FilePath
      chrootdir = "/srv/chroot" </>
                  case dist of
                    (Debian suite) -> Apt.showSuite suite ++ "-" ++ arch
                    (Buntish suite) -> suite ++ "-" ++ arch
      os = case dist of
             (Debian suite) -> osDebian suite arch

But when I use it I get this error message

i686-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/lib/python2.7/dist-packages/numpy/core/include -I/«PKGBUILDDIR»/src -I/usr/include/python2.7 -c /«PKGBUILDDIR»/python/cython/_fisx.cpp -o build/temp.linux-i686-2.7/«PKGBUILDDIR»/python/cython/_fisx.o
ccache: error: Failed to create directory /var/cache/ccache-sbuild/9/1: Permission denied
error: command 'i686-linux-gnu-gcc' failed with exit status 1
E: pybuild pybuild:274: build: plugin distutils failed with: exit code=1: /usr/bin/python setup.py build

picca@ORD03037:~/Debian/python-fisx/python-fisx$ ls -l /var/cache/ccache-sbuild/
total 76
drwxr-xr-x 2 root  root            4096 juin  16 15:48 0
drwxr-xr-x 2 root  root            4096 juin  16 15:48 1
drwxr-xr-x 2 root  root            4096 juin  16 15:48 2
drwxr-xr-x 2 root  root            4096 juin  16 15:48 3
drwxr-xr-x 2 root  root            4096 juin  16 15:48 4
drwxr-xr-x 2 root  root            4096 juin  16 15:48 5
drwxr-xr-x 2 root  root            4096 juin  16 15:48 6
drwxr-xr-x 2 root  root            4096 juin  16 15:48 7
drwxr-xr-x 2 root  root            4096 juin  16 15:48 8
drwxr-xr-x 2 root  root            4096 juin  16 15:48 9
drwxr-xr-x 2 root  root            4096 juin  16 15:48 a
drwxr-xr-x 2 root  root            4096 juin  16 15:48 b
drwxr-xr-x 2 root  root            4096 juin  16 15:48 c
-rw-rw-r-- 1 picca instrumentation   16 juin  16 16:32 ccache.conf
drwxr-xr-x 2 root  root            4096 juin  16 15:48 d
drwxr-xr-x 2 root  root            4096 juin  16 15:48 e
drwxr-xr-x 2 root  root            4096 juin  16 15:48 f
-r-xr-xr-x 1 root  root             172 juin  16 15:48 sbuild-setup
drwxrwxr-x 2 picca instrumentation 4096 juin  16 16:32 tmp

RSS

comment 1

here the manpage fo ccache

SHARING A CACHE
   A group of developers can increase the cache hit rate by sharing a cache directory. To share a cache without unpleasant side effects, the following conditions should to be met:

   ·   Use the same CCACHE_DIR environment variable setting.

   ·   Unset the CCACHE_HARDLINK environment variable.

   ·   Make sure everyone sets the CCACHE_UMASK environment variable to 002. This ensures that cached files are accessible to everyone in the group.

   ·   Make sure that all users have write permission in the entire cache directory (and that you trust all users of the shared cache).

   ·   Make sure that the setgid bit is set on all directories in the cache. This tells the filesystem to inherit group ownership for new directories. The command “find $CCACHE_DIR -type d | xargs chmod
       g+s” might be useful for this.

   The reason to avoid the hard link mode is that the hard links cause unwanted side effects, as all links to a cached file share the file’s modification timestamp. This results in false dependencies to
   be triggered by timestamp-based build systems whenever another user links to an existing file. Typically, users will see that their libraries and binaries are relinked without reason.

   You may also want to make sure that the developers have CCACHE_BASEDIR set appropriately, as discussed in the previous section

it seems that a a setgid bit is required for all directory.

Comment by picca — Fri Jun 17 07:50:41 2016

Remove comment

comment 2

Thank you for reporting this and for finding the fix, Fred. In a branch I'll be submitting soon I have modified Ccache.hasCache to chmod setgid the cache root, and this should propagate to all newly created subdirectories.

Joey: what do you think about adding cmdProperty "chmod" ["-R", "g+s" "/var/cache/ccache-foo"] to Ccache.hasCache to fix existing broken setups? In my view it would be better to just add a note to the changelog suggesting this fix, but I'm not sure what you think would be best.

Comment by spwhitton — Sun Jun 19 07:19:33 2016

Remove comment

comment 3

I generally try to fix up after bugs in the implementation of properties, because otherwise maintaining my hosts gets problimatic.

In this case, the sbuild support is pretty new and probably not much used, so I guess it's up to you. chmod -R is rather expensive. If there's a cheap way to detect when that's needed and only run it then, that would be ideal..

Comment by joey — Mon Jun 20 17:53:24 2016

Remove comment

comment 4

I found a way to do it and committed it to the branch we're discussing elsewhere.

Comment by spwhitton — Tue Jun 21 08:57:02 2016

Remove comment

Add a comment